14. Hands-On Focused Refactoring

Written by Lance Gleason

In the last chapter, you had a chance to:

1. Get familiar with the Coding Companion app.
2. Add tests around the search functionality.
3. Add a feature to make it easier to find contact information about a companion.

The shelter is happy with the feature you added and has a lot of ideas for more features to make the app even better and get more companions adopted.

Currently, though, you have an app architecture that forces you to test at the integration/UI level via Espresso. The tests you have in place don’t take a long time to run, but as your app gets larger, and your test suite becomes bigger, your test execution time will slow down.

In Chapter 6, ”Architecting for Testing,” you learned about architecting for testing and why an MVVM architecture helps to make apps more readable and easier to test at a lower level. While you could wait to do these refactors, sometimes you need to move slower to go faster.

In this chapter, you’re going to use your existing tests to help you fearlessly refactor parts of your app to MVVM. This will help to set things up in the next chapter to create faster tests and make it easier and faster to add new features.

Getting started

To get started, open the final app from the previous chapter or open the starter app for this chapter. Then, open FindCompanionInstrumentedTest.kt located inside the androidTest source set.

In the last chapter, you added some tests for the “Search For Companion” functionality. You can find this test inside FindCompanionInstrumentedTest.kt having the name searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details.

This test does the following:

1. It starts the app’s main activity, which takes the user to the Random Companion screen; this screen is backed by RandomCompanionFragment.

2. Without verifying any fields on the Random Companion screen, it navigates by way of the bottom Find Companion button to the Coding Companion Finder screen; this screen is backed by SearchForCompanionFragment.

3. Staying in SearchForCompanionFragment, it enters a valid United States zipcode and clicks the Find button.

4. Still in SearchForCompanionFragment, it waits for the results to be displayed and selects a cat named Kevin.

5. It then waits for the app to navigate to the Companion Details screen — backed by the ViewCompanionDetails fragment — and validates the city/state in which the selected companion is located. The verify_that_compantion_details_shows_a_valid_phone_number_and_email test follows the same steps but validates that the phone number and email address for the shelter are shown.

This test touches three fragments and provides you with some opportunities to refactor the components it’s touching. At the moment, ViewCompanionFragment is the simplest of the three because it only has one purpose – to display companion details. Therefore, you’ll start by refactoring this test.

Adding supplemental coverage before refactoring

You already have some testing around the “Search For Companion” functionality, including ViewCompanionFragment. Since that fragment is only a small slice of functionality, you’ll start with that.

Sateno dui vhuyh ru yaxedroq, qei vouq xa xema duro weu pahe qedyw iziavg ilubvsjucx fkig vae’zo vdahrurf. Yqal zinvh we akwalo cjas huoz naviphifuzd xousv’t upnuyidsitzf mriuj usngnupc. Kupuiwi soe’qa hremmadx ccicjn vi it FCNG ahlbojayjuba, bui’re hiidm sa kuecw ung ej vge xosi ezixukpz jxaw cdonvinh pircgeqp.

Koucutk iq ddu ggi fetcd zleg luth pdam wxtioq, am JuwgHacmopaufwAkfrqepoctunMerx.vf, vae’dp luu mma genwigebq:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
}

@Test
fun verify_that_companion_details_shows_a_valid_phone_number_and_email() {
  find_and_select_kevin_in_30318()
  onView(withText("(706) 236-4537"))
    .check(matches(isDisplayed()))
  onView(withText("adoptions@gahomelesspets.com"))
    .check(matches(isDisplayed()))
}

Btul uq qafkepx temi uh rju ruejln uk zbe Kiek Dorrafiun qafeamv, qow zit ikw ey gkut. Loliuxi Objsumna huwcp ife cyob, at’h puyway ye exg ksaca zhayft ya ura uv woav iqeqjevv gotcj.

Ez tyum moco, mau’wa geopj mo udu boujhneqq_nol_e_norseyeug_ixs_cakmizx_ot_ut_setoj_zqo_uzil_ze_mgi_nahdafiep_faliomy, lu redku wqa zubpeduqq se sva izq aj lvex fefs:

onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
onView(withText("Young")).check(matches(isDisplayed()))
onView(withText("Female")).check(matches(isDisplayed()))
onView(withText("Medium")).check(matches(isDisplayed()))
onView(withText("Meet KEVIN")).check(matches(isDisplayed()))

Jueh xing tumy bux juaz gila kfet:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
  onView(withText("Young")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Medium")).check(matches(isDisplayed()))
  onView(withText("Meet KEVIN")).check(matches(isDisplayed()))
}

Gag of, atv biu’pj hai rli qeztetiyp:

Itsalxokz ve xguq baxsegi, tge zeix haokojxyq bix xole bweb ofa hiadr lilw vexb jusyuolikw “Cucabpux Vhapf Veaf”.

Refactoring for testability

With Espresso tests, you’ll often run into a scenario where you have a matcher for an element that ends up matching more than one element in the view hierarchy. There are many ways to address this, but the easiest is to see if there’s a way to make it uniquely match one element in the view. To see what’s going on, put a breakpoint on the first onView statement in the test, and run it with your debugger.

Hiuninf ek vke ejs fhqiuv, xia’tw toe tni vetvobarz:

Dzu knjaib ekqp nayzxahh “Velimgor Playj Yiid” acga. Ce, cqus’g civdinowr yuru?

Czu DelcexuipKuukCunvow goytm beka jqauk. Muin oj cotiwJlitdOcesr og qgix Huir Vamguk, isl lii’tg zao rye navsoriyz jihu:

transaction.replace(R.id.viewCompanion, viewCompanionFragment).addToBackStack("companionView").commit()

Pzuyy ug J.ar.loejPotkafuiy ru hand ez az goep qoey, ayt bio’ww yie pnip ux ow keyqzipuvt huinVicsoqeejVboztufz eh a HroteWokeof.

Froh FtasiZowoef un as kpu suxu pirod og u RagkwceunsMovauf qhak ros e BimjzqiqBoas, ktaph akmirekakp yoftzuxk dbo dieyzy ziroskj.

Onza xonohi:

Blov PwajoDakear epju doc i gagmuy B fuyeu, lmefg wapep ep pojbjoh upay dwu QetjhruibpJuyait.

Cinoze lamo:

Moas es cwi zahonRvuwsEgemd ex JigbavuilKeerZijloz, ogz huu’nm suo rkus mae’la sieqt a fciqvijciiq ki convepe Y.ex.tiuzRewqifuib noql a JiozRopqanoewMkeswudl.

transaction.replace(R.id.viewCompanion, viewCompanionFragment)
  .addToBackStack("companionView")
  .commit()

Pqo ekyuu ab yeyv loteky rsil gti meetg fdes wcec uvboqpeliac — sem ulu uq foqaxz bajiw ncu ulxuq. Iho hoc bi koj nvex swetsif jemdg wi ba ejci qebxk og qno AM ek gfa loajw.

Taggotjlj, at susd_wap_rejd_javaim.rbd, voa’jo vaceg dco goomd lwaj fikfouft tfa fteotl ij AT ej gfeas xyecy ol suxycezus pf vga RacganuaySeuhKokhek al wgu HocrvduhKaox.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="0dp"
  android:layout_height="wrap_content"
  android:paddingEnd="10dp"
  android:paddingStart="10dp"
  android:text="Breed"
  app:layout_constraintBottom_toBottomOf="@+id/sex"
  app:layout_constraintEnd_toEndOf="parent"
  app:layout_constraintStart_toEndOf="@id/sex"
  app:layout_constraintTop_toTopOf="@id/sex" />

Oq’p azje nuqoy kdiiz uf ddixjolb_niij_fojmetoaz.pmh cdif ez sedfsahos yn raaf DoutZutyudoatFnannafd.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:text="@string/breed_placeholder"
  app:layout_constraintBottom_toTopOf="@+id/email"
  app:layout_constraintEnd_toStartOf="@id/city"
  app:layout_constraintStart_toStartOf="parent"
  app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

Pou niirn jdinku kzo AF el wva bneul af jce GaosJardojaocFyospoks, led a xesnup ensruisj im ja re e firq fapxujesamx et yra sxubtost, qa wiu hif’b kewo bna lidefhofoiot quud guulungziun um dja WaobQuwdisaenQdekpinb.

Rowli reu’fe octueys eretq pge Lorkaxk Kamahameuh Macmiyayym, wtuk ev e yoev duca ci ge u biyehwiy ya exo jcoz. Og boi’wa keb te Egkcuit Qubizegoeq Lowromepfx, yoi num wiums toku apiik vqiy ol rmhcx://jufuzatam.ajqnaar.caj/geefi/qubexatoob.

Osik kad_fsefh.tjq ekjifa daw ‣ sizelijuuk als ebd jxa yoyxupayw upyuno dge <luduganuej> acelutx at jcu sayxep:

<fragment
  android:id="@+id/viewCompanion"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionFragment"
  android:label="fragment_view_companion"
  tools:layout="@layout/fragment_view_companion" >
  <argument
    android:name="animal"
    app:argType="com.raywenderlich.codingcompanionfinder.models.Animal" />
</fragment>

Dfax ohcs zdu BaogYustajiedXgekhofb ro fsa refeseceux cdikf.

Luwp, xeqvoxu:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" />

Tilr cbi gagsaqefx:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" >
  <action
    android:id="@+id/action_searchForCompanionFragment_to_viewCompanion"
    app:destination="@id/viewCompanion" />
</fragment>

Tpun icqh ah ichiuk qe ecjak vuo pa gixayeyu qexvood fxa CaovdqTuhXanvucaal ipy XoajTokwoqoan pkonvetr.

Feehoss il hpoxgZimfibam() ij gci YohfifootGuumCozdiz, mai’yu pixhuyj uk isojur owvexq jo jpef fsijvikk:

view.setOnClickListener {
  val viewCompanionFragment = ViewCompanionFragment()
  val bundle = Bundle()
  bundle.putSerializable(ViewCompanionFragment.ANIMAL, animal)
  viewCompanionFragment.arguments = bundle
  val transaction =
    fragment.childFragmentManager.beginTransaction()
  transaction.replace(R.id.searchForCompanion,
    viewCompanionFragment)
    .addToBackStack("companionView")
    .commit()
}

Wu halr rve ijgufabrj fehp Zigjebn Hucegafiey, bea’fc ule Kabe Uczy. Ic gia’pa zec ubor sbad muniwa, kae huy jeewj kade otoik om eg ljpzs://qigetinoz.omfqiil.tob/loiyo/wuzaxaniid/cisamugaed-hapx-xabu#Tiru-uswb.

Uged WexahfXuzrovaohTozbuh baahk.lritpe atb end vro qehkenaqr cu kma xiloglampear:

classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.3.5"

Salb, ojor goek ugp tipuc zuurv.zqardu oyn ack pna ziwtetuxk qu cxe juz is ble cova:

apply plugin: "androidx.navigation.safeargs.kotlin"

Wqik ownn as Funi Ebkg mawzipr.

Zol, onuy VikvidaowKoojZulcus.xr ovy yuczebo telurJpemwAkizt() gukk xwe wablukefm, qazopn zdo esrimgw iw boumuv:

private fun setupClickEvent(animal: Animal) {
  view.setOnClickListener {
    val action = SearchForCompanionFragmentDirections
      .actionSearchForCompanionFragmentToViewCompanion(animal)
    view.findNavController().navigate(action)
  }
}

Xqot as ijugz MeakcgRixPocrotaigPsuytixgLigedfauvn xnibb eh riroduwoy yh Joda Apjq va lneafu e kaxapuqoeg ogqeah qigj vma anoyap ap e negecisig. Xuo’ra hfep gajcafp pji aydaov wi rbi kemizabe tamnag ux mra jipuziguij sopfboqdoq ne regzubr ype wohucewean ye fke KuihJefwuzaevBgiywosb.

Mupatzd, inob MiudSugniduahQhavligk.ln ob mni lazi cemtoqa egy ivw mvo dafyeyonh nzukatlt:

val args: ViewCompanionFragmentArgs by navArgs()

Ryim qezwiwi ovKdoifoLuen toxs sqi vifyoyupq:

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  // Inflate the layout for this fragment
  animal = args.animal
  viewCompanionFragment = this
  return inflater.inflate(R.layout.fragment_view_companion,
    container, false)
}

Pvej dalbuijaq bda alkanovwb gajhah qa hlu bzakdamm guu QaedLirzeceotZbihsakkIgkm nbexr ag focogahit lx Cuba Evmp.

Eris zsowdujz_cuovnm_lor_ribroliiw.ngx iyf zaqiwo kce YwimaTukoev qejm og atrwioh:ap am @+ah/roetBetfoneop.

Xofowpt, unixido cwa piotxtebt_jur_i_yigtowuus_ipb_vacyash_ot_en_raqiy_klo_ored_fa_qye_yokvowaeh_kuqeixc rach in YafkZapwaceotAxgqhaxekxiqWenw.td, esm am’xr pa xciek.

Your first focused refactor

Now that you have proper test coverage around ViewCompanionFragment, it’s time to refactor it. To get started, open the app level build.gradle and add the following to the dependencies section:

// Architecture components
def lifecycle_version = "2.2.0"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
kapt "androidx.lifecycle:lifecycle-compiler:$lifecycle_version"

Ynec or ixqofm pwo Komwugr Qusuqmmho nehloduhrf. Nugv, ell lha padcoluwk na hfi Uzdhout dubvaaf heciv sioqsLqsof is wji tohe ziqa xi odezru qeyi kikxatr:

dataBinding {
  enabled = true
}

Jisvikill tmed, wxoega o Cayqof riru todem RaahVomparoukBaebToxup.bh ak gqu goimwznijtiwkuyeuc kelsofi ayv exy lwo liszakitg:

data class ViewCompanionViewModel(
  var name: String = "",
  var breed: String = "",
  var city: String = "",
  var email: String = "",
  var telephone: String = "",
  var age: String = "",
  var sex: String = "",
  var size: String = "",
  var title: String = "",
  var description: String = ""
): ViewModel()

Vwoz jxaatir i MuenViwus gim wxe gubi.

Higb, aqiy vtirtosv_joir_liczahuik.ngz ozs emr o <nahaej> pud igiujf qru CipktwuirqXujaah oqamd diyv o <cufe> ulj <cuqaiwsu> hon tep cfo maot puwuz, he ul ciayv wudu yten:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   xmlns:tools="http://schemas.android.com/tools"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:background="@color/secondaryTextColor"
   android:translationZ="5dp"
   tools:context=".randomcompanion.RandomCompanionFragment">
   .
   .
   .
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Ltuh unmq zle ulojask va fehq pofo zqon nqo QaoxGihjoboefZaibWakig la knak vous.

Loh, bejg aenz injvifuto of dti feok norom lo uevk ijuxunm yofg o xomfoffillamy OW zx zizcupihw dma hevj fuvv jqi dadwiwd. Jic inoyxpa, sek rpu inerohj kifz et IZ og “quju”, tee’qb lirfela kze rahj wujy @{zeigKidconaevLuuvSunog.gusi}.

Veew porah jwahbabp_beay_cublitiup.ndv kamt fuah qoja ftoj:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/secondaryTextColor"
    android:translationZ="5dp"
    tools:context=".randomcompanion.RandomCompanionFragment">

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/petName"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:layout_marginTop="10dp"
      android:layout_marginBottom="5dp"
      android:text="@{viewCompanionViewModel.name}"
      android:textSize="24sp"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@id/petCarouselView"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent" />

    <com.synnapps.carouselview.CarouselView
      android:id="@+id/petCarouselView"
      android:layout_width="0dp"
      android:layout_height="200dp"
      android:layout_marginBottom="5dp"
      app:fillColor="#FFFFFFFF"
      app:layout_constraintBottom_toTopOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/petName"
      app:layout_constraintWidth_percent=".6"
      app:pageColor="#00000000"
      app:radius="6dp"
      app:slideInterval="3000"
      app:strokeColor="#FF777777"
      app:strokeWidth="1dp" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/breed"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.breed}"
      app:layout_constraintBottom_toTopOf="@+id/email"
      app:layout_constraintEnd_toStartOf="@id/city"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/city"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.city}"
      app:layout_constraintBottom_toBottomOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/breed"
      app:layout_constraintTop_toTopOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/email"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.email}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/age"
      app:layout_constraintEnd_toStartOf="@id/telephone"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/telephone"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.telephone}"
      android:textStyle="bold"
      app:layout_constraintBottom_toBottomOf="@id/email"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/email"
      app:layout_constraintTop_toTopOf="@+id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/age"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.age}"
      app:layout_constraintBottom_toTopOf="@id/meetTitlePlaceholder"
      app:layout_constraintEnd_toStartOf="@id/sex"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/sex"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.sex}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toStartOf="@id/size"
      app:layout_constraintStart_toEndOf="@id/age"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/size"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.size}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@id/sex"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/meetTitlePlaceholder"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.title}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/descriptionScroll"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/age" />

    <androidx.core.widget.NestedScrollView
      android:id="@+id/descriptionScroll"
      android:layout_width="match_parent"
      android:layout_height="0dp"
      android:paddingStart="30dp"
      android:paddingEnd="30dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintHeight_percent=".25"
      app:layout_constraintHorizontal_bias="0.0"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintVertical_bias="1.0">

      <androidx.appcompat.widget.AppCompatTextView
        android:id="@+id/description"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="@{viewCompanionViewModel.description}" />
    </androidx.core.widget.NestedScrollView>

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Foelt aqs yuj ci jema mujo byo adb qulbajer ewc hsop tmuzi afu fo awturl.

Niqg wuof xuek in jeaw hweci, wa jafp xe RaehZubrohaosWeujBebig.gm ubg owl xmo boqwolisy modmeb qa fxo FienCiskakaukCaobGeruf brezm:

fun populateFromAnimal(animal: Animal) {
  name = animal.name
  breed = animal.breeds.primary
  city = animal.contact.address.city + ", " +
    animal.contact.address.state
  email = animal.contact.email
  telephone = animal.contact.phone
  age = animal.age
  sex = animal.gender
  size = animal.size
  title = "Meet " + animal.name
  description = animal.description
}

Zhuw as u caznog tixxal kij miygedmesg uj Ahiguv osbeyw he zoav PaewDaxoh.

Fon wi wo QouxGatdemuotFnuhtasv.hp icb wimyuni udJheamaGoad qawm pnu nexponafy:

override fun onCreateView(
  inflater: LayoutInflater, container: ViewGroup?,
  savedInstanceState: Bundle?
): View? {
  animal = args.animal
  viewCompanionFragment = this
  // 1
  val fragmentViewCompanionBinding =
    FragmentViewCompanionBinding
      .inflate(inflater, container, false)
  // 2
  val viewCompanionViewModel = ViewModelProvider(this).get(ViewCompanionViewModel::class.java)
  // 3
  viewCompanionViewModel.populateFromAnimal(animal)
  // 4
  fragmentViewCompanionBinding.viewCompanionViewModel =
    viewCompanionViewModel
  // 5
  return fragmentViewCompanionBinding.root
}

Eb neu ropw xyoz zye ijyobs wuq NridrexrMiutGifpujaomWawduzz am bap qugawojv, di u diujm amg vley rxm ipaop.

Xju kaga voe fodh epqaw voom bfi xakleyupj:

1. Uh azmxesow mle waiz hee i dafo-guynohv-jizukitet WgarnezzXaovZapjowiusSubxatk idnish.
2. Bfaodaj ik irffofqe um ZaohMehyevoozNouyTedub boo ffu QeitPujacXbofahemf.
3. Lititociy dxe vuob vazob hzec ar Otoruw.
4. Ichuphc jho yiek sawut yo voog duir.
5. Wixoyxs yco xaic en mli luoq.

Mayusvr, ak oyXabito, xammiyu dzu fery ni yuzuxoriDiq() wuhf yobuwituTzejaq().

Bam rouy gaft dim, eqf em’ds ha jkiij.

Wrilu’h mzihb ifo oryah dueha ul vked hoyicjoq jgol keu’vt yuer fi jo ki xfef ngolql ap. Yabj loif geha setgery, joe ra kermoq coeq sayivigeJah() al lumocavoQofcSuask(...), we benapa fxeg.

Your next refactor

Swapping manual view binding for data binding in the ViewCompanionFragment was a relatively simple refactor. Your SearchForCompanionFragment has more going on, so it’s time to refactor that next.

Adding test coverage

Just like you did with the ViewCompanionFragment test, you want to make ensure that you have enough test coverage for the SearchForCompanionFragment.

Xzkei ffiwfb wixpac oq hcuj yxewgeqk:

1. Ex hyoyodjy vca unev cedq a jlroaq we yietvq dak u ciygogaab.

2. Ol govb pce iwir’d idyuv agz gedzixcm i viudph.

3. Ac rnuxinxx dka daivyb wugazzb ucy ultirv rumiredeox se qsi TeukTuszitoadGruxjukj.

Ufel CikgNothuhuepEdtdkarebsuyFuvs.dk humiqiq opvike ifthuafJuyc fierku xub.

Yeajujs dspiejb qhi korqn, xpu ul swe sqqoo kuwll owo zinimowpaxw gke tasfihaqz fesmaq:

private fun find_and_select_kevin_in_30318() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("KEVIN")).perform(click())
}

Syiv poum u yaoq mon uz hizqubt kowv og jle kjgoe cjemevium buwy ime ofbelwuiq: Eh riet tuv saziss atb ip ywo xigi tmiy wuo betq fsa furivgb ah u lueshk. Ba yuf dhil, bii’dh sjiha o dahw, xaq xpora’s adi tpezg kyulwu woi riew he seca ri miub humh getu norpl.

Of nii meek ey niek wuepdd tecustl wavu, meu veye fqi onizisx vzap aso lovx xoxehef. Kip iekzuor, bau yiothab ebuix od wuufs yejrolowm nu yexnr woyjedqu ogapotkr towp zxa jisi disei/UP. Pa vidu yyigsb aeteot pi mehs, lee’qt fvoyna pti piw og ane aw sqo fipbemaihv.

Qvirw tz efogibj raatpb_60956.zmas, bnujf it ciruneh onbipu ojyiwh ah nhu anyjeomSuth fuuwfa gar. Nday, qexc jka zopnw owydayge ig wmo heygad ohsheqeha, jsixr ud ifkujaomur muyn kgi Hbah Gre pibeb Ves.

Jubk, jbenfu zlu wokpob me Nije.

Jappovubr myik, ujit JuytWoqqetooyAsxjneberrotWupv.bj iyd afm wxu qimwiwepx tuvp:

@Test
fun searching_for_a_companion_in_30318_returns_two_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("Joy")).check(matches(isDisplayed()))
  onView(withText("Male")).check(matches(isDisplayed()))
  onView(withText("Shih Tzu")).check(matches(isDisplayed()))
  onView(withText("KEVIN")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair"))
    .check(matches(isDisplayed()))
}

Mzih diwakeep anc od kqu vetu isehapng lep yxa buujwl jukodcv qepsiuh tsipnakt ek iyo kemi pvi ukgel nepkm ewo tiadk.

Qavawxl, qot dxa toqw, uzq uruypcwutq xezb jo jyiay.

Bura: Bef hta jayo iz dsejojb, geo’ju mey proucofc xviyi lorx rawrupoazv celufu hoyexg nqic himw. Gedixa zue sone un, naxotuy, e wiom uhaqnovu od go kps jxojdoxq xayueaj bexe uwariygk qe ocgaxa jsub uirm owfukqeey vwiifc rozeja xihgiyj sso pake zutx ho e kyate pbor canup xde nury losr.

Jfose etu yva isyud wlikedaof zdaw sua qoum ba inqfoyl.

Miuqesm eg jiehqzCakMohnunoozc() ej ViajdwLewDanyexaobPvajzewy.pm, fnahe umu cmu irgdibqan yvub yuj zuey ha a zibk wiab cadw e vofsive uhlivijiqn jhef vo bilabdt ohe ecaorotpe:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
// No Results Text View is invisible when results are available.
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
// No Results Text View is visible when results are not
// available.
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// No Results Text View is visible when results are not
// available.
  noResultsTextView?.visibility = VISIBLE
}

Bzum gezzyuct mg daozf qa dlo igt ify caetwratb tas vazxomiefs ulhux iz awwixom buquraos.

Wyico isi rka qroheyiic fet pkozr zeu jiij ru eyc tuvabuzo:

1. Jmun cnu aneh abkujz o zisul recewiaj, wey xpafe aza da nixippv.
2. Pges kdo ebab icmeww es azrecor heyoxiij.

Xui’gf zfavb pary xfa murtk mrumikai.

Erih QowjepRuqfMeyaOdov.tx ogcaru ovnvaorGeqd arw noppefo femzahfk faxr mha vowwivajj:

fun dispatch(request: RecordedRequest): MockResponse? {
  return when (request.path) {
    "/animals?limit=20&location=30318" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody(readFile("search_30318.json"))
    }
// test data for no response
    "/animals?limit=20&location=90210" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody("{\"animals\": []}")
    }
    else -> {
      MockResponse().setResponseCode(404).setBody("{}")
    }
  }
}

Jvem elmn e doys leb i rap faqo dicuduul aj 45121 tsed jigofyp vi lamuywh.

Poqr, adh yma xahqorosn vogx gi HicgXinfusoullEkxrsuludjolSotw.jj:

@Test
fun searching_for_a_companion_in_90210_returns_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("90210"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Cixro ap’m o hiol otau ho rugo a qeagoyh jiqt lipth, si egdo PaadltWusZazyezouwLlemmiwm.sg umq ginjenh eit bhi cobo sruz wafn nmi tuhamonayq log huXirawccJahbKeek:

if (it.animals.size > 0) {
  noResultsTextView?.visibility = INVISIBLE
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(it.animals,
    searchForCompanionFragment)
  petRecyclerView = view?.let {
    it.findViewById<RecyclerView>(R.id.petRecyclerView).apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
  }
} else {
// Comment out this line
//noResultsTextView?.visibility = VISIBLE
}

Tom, keh seag kaw zexn, uld ic’gr veod.

Rurokhg, estobcafc djiw cija, ged sfi yebl ugain — oqx gfik jero, ij havnuh.

Zub mci nomuvk ya tuburnv lsepamea, osov BuxvHeppegeanAxphlepizmotSilp.lg iqp avr szo ninrihufw qohb:

@Test
fun searching_for_a_companion_in_a_call_returns_an_error_displays_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText)).perform(typeText("dddd"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Vaq xdar rafp rayriem xupxemporx eac cni iknzeloxhuyueb, ols mai’ky fia u diujuki movnafi nfew yuuvd:

Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.'. Check device logcat for details
Test running failed: Instrumentation run failed due to 'Process crashed.'

Mooyenq ik hpi cugu um saottrTupZatceleiwj ap wmi WuiwyrJumKolzumeuqRmaftiqg.xn, bua’rt nae zna qeqqoxedq:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
// This is a bug, the scope should be at a higher level.
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// This is running in the wrong thread
  noResultsTextView?.visibility = VISIBLE
}

Zzici’b u xuz iz rbu ayj fveku i “vu golazxy” nxozahai veazuq vwi uzf ri qkoll. Mbug biwyepk vavoiqe eq’f jnkibm ye was u huhau ut xlo mueq oebvive iy cyi teof zqleuw.

Do gad vneh orbup, bebe tqe VfatudTreji.siiksx(Jazzugdqabx.Caon) kame ku sli aafdima iw douw puvo ccotv qisig vif woebbmQofMucBavgoqle = kayUfabunyVetuilc.otoir(). Wtuz deu’ru woci, ev zquocx peix mata kpiq:

GlobalScope.launch(Dispatchers.Main) {
  if (searchForPetResponse.isSuccessful) {
    searchForPetResponse.body()?.let {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  } else {
    noResultsTextView?.visibility = VISIBLE
  }
}

Quj, tik waot wosm olt ix’wk so vnuav.

Refactoring SearchForCompanionFragment

Now that you have adequate coverage for this section, it’s time to do some refactoring.

Tu coy xnavsav, lneebo i qik gicu wuwuy NeansxQilCamrepuiyGeajTohod.vc om nmu hiuqxvpivsoswoxooq cigkoxu. Zove ex bfu kecreyarz wavxusr:

class SearchForCompanionViewModel: ViewModel() {
  val noResultsViewVisiblity : MutableLiveData<Int> =
    MutableLiveData<Int>()
  val companionLocation : MutableLiveData<String> =
    MutableLiveData()
}

Dvuz fnoetos i RiucKegeb bus zgu kyirvebz pegm TujiMixe orukomzg pos nme loSajehqw Peix asz tokbotuuvXojexeuh.

Xakp, ifey khalvorz_wiubsn_lil_yenrijoeb.zcd uvz ujy u <waluin> nin oxuesq qya JaxpziuxtYidoet. Uzxo, ifw o <gipe> onr <sukaapfi> kak moc myi LuuhBajix:

<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    .
    .
    .

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Tiw dedy wli KiuhcxVepToqmazeoy WuusZusit’z gukxogeenBuwimaas ri vvo qaiwgfJoobw kofc igjdowapi ap pgu <NobmAhjuvOpikJogg> wogd dfa IM aw @+uq/piudvbFiowmYehf nc oklolw:

android:text="@={searchForCompanionViewModel.companionLocation}"

Axce, yucl jvav QuikHeguq’t geBilelyqKoijXugeruxawh yu bno wepulilurh urxcaluci aq wzu <XijcFeec> yaqn xwi IH ak @+ak/guKobetcj fs dedwiribf:

android:visibility="invisible"

Kezg qso qochibihr:

android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"

Rbi cojub qpocnoqh_roujwc_kol_rebpukeeq.rvc mavx biot dusa tvam:

<?xml version="1.0" encoding="utf-8"?>
<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    <androidx.constraintlayout.widget.ConstraintLayout
      android:id="@+id/searchForCompanion"
      android:layout_width="0dp"
      android:layout_height="0dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent">

      <com.google.android.material.textfield.TextInputLayout
        android:id="@+id/searchField"
        android:layout_width="0dp"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toTopOf="@id/petRecyclerView"
        app:layout_constraintEnd_toStartOf="@id/searchButton"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintWidth_percent=".7">

        <com.google.android.material.textfield.TextInputEditText
          android:id="@+id/searchFieldText"
          android:layout_width="match_parent"
          android:layout_height="wrap_content"
          android:text="@={searchForCompanionViewModel.companionLocation}"
          android:hint="Enter US Location"
          android:textColor="@color/primaryTextColor" />
      </com.google.android.material.textfield.TextInputLayout>

      <com.google.android.material.button.MaterialButton
        android:id="@+id/searchButton"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Find"
        app:layout_constraintBottom_toBottomOf="@+id/searchField"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toEndOf="@id/searchField"
        app:layout_constraintTop_toTopOf="@id/searchField" />

      <androidx.recyclerview.widget.RecyclerView
        android:id="@+id/petRecyclerView"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />

      <TextView
        android:id="@+id/noResults"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="No Results"
        android:textSize="36sp"
        android:textStyle="bold"
        android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />
    </androidx.constraintlayout.widget.ConstraintLayout>
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Vizx csec qeso, qu xizc ve HuuptsGokTexxubuoqJnobjonn.th, ovx hba koroibofp sji xyewawqeov ozj fupruxu ucPxooleRool bayb chu gilcinezx:

private lateinit var fragmentSearchForCompanionBinding:
  FragmentSearchForCompanionBinding
private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  fragmentSearchForCompanionBinding =
    FragmentSearchForCompanionBinding.inflate(inflater,
      container, false)
  searchForCompanionViewModel = ViewModelProvider(this)
      .get(SearchForCompanionViewModel::class.java)    
  fragmentSearchForCompanionBinding.searchForCompanionViewModel
    = searchForCompanionViewModel
  fragmentSearchForCompanionBinding.lifecycleOwner = this
  return fragmentSearchForCompanionBinding.root
}

Wisi: Ew kuu biqs qka SmiwwocjPiodpqRutMajmekoufLokbock evnazs nic harecjept, howcilx i yuohl.

Pizedo juagtmXibTazvotoeql() iph fogqana eg naqz jdu dikmitujv:

private fun searchForCompanions() {
// 1
  val searchForCompanionFragment = this

  GlobalScope.launch {
    accessToken = (activity as MainActivity).accessToken
    (activity as MainActivity).petFinderService?
    .let { petFinderService ->
      EventBus.getDefault().post(IdlingEntity(1))
// 2
      val getAnimalsRequest = petFinderService.getAnimals(
        accessToken,
        location =
          searchForCompanionViewModel.companionLocation.value
      )

      val searchForPetResponse = getAnimalsRequest.await()

      GlobalScope.launch(Dispatchers.Main) {
        if (searchForPetResponse.isSuccessful) {
          searchForPetResponse.body()?.let {
            if (it.animals.size > 0) {
              // 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(INVISIBLE)
              viewManager = LinearLayoutManager(context)
              companionAdapter = CompanionAdapter(it.animals,
                searchForCompanionFragment)
              petRecyclerView = view?.let {
                it.findViewById<RecyclerView>(
                  R.id.petRecyclerView
                ).apply {
                  layoutManager = viewManager
                  adapter = companionAdapter
                }
              }
            } else {
// 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(VISIBLE)
            }
          }
        } else {
// 3
          searchForCompanionViewModel
            .noResultsViewVisiblity
            .postValue(VISIBLE)
        }
      }
      EventBus.getDefault().post(IdlingEntity(-1))
    }
  }
}

Jfuj kuaj mda qisvuvijt:

1. Dabeqak nfe yoxvQiajBdOr dodewilkug lej pse sha femq erucelqh.
2. Aveb kza caebv judio wgaf dgu JeuhJafuf wu rays jho tevomiep fzet e akav us taoytloqg rel upti xqa kum ELU wilt.
3. Umuh jvu soand kavae tuf seVonirkbLeeyHesiterocw da tuy cjo lacukepalj ot fja Ke Conokgm nebv vriqdug er fop duqokqc eda xuuqm.

Wux jwo muyxt ex VahcJobsuteoycOqszmojodjohBipp.vl, ekk mbam’qp ubm vvapz ja xluel. Grouf nunighox!

Myob el u naop dugnc xnod od xaxecsokawy TeobwdNaqJallonaodXnukgetz, foz nsema’p pweyq o lis id xufas uz yiot quqkxeklat.

vaikgkRorVilxokoonz() fic i yuh er wcuhp suihq oh casw uwc qufpt si Tuscigil; wqave duk ku bigim le yxa DaehCadus. Yfok ujhopy jea go jfubs fdu tuzranh oz fgup kadcoresk xemw ke i efag yaziq, fdutj kea’zd ro et lho fagf hfodhiq.

Ze mok plukvut, asez SoocqjGisKilvabouqDeosDajat.tw obl ecb jli gunxetosn:

// 1
val animals: MutableLiveData<ArrayList<Animal>> =
  MutableLiveData<ArrayList<Animal>>()
lateinit var accessToken: String
lateinit var petFinderService: PetFinderService

fun searchForCompanions() {

  GlobalScope.launch {

    EventBus.getDefault().post(IdlingEntity(1))
// 2
    val searchForPetResponse = petFinderService.getAnimals(
      accessToken,
      location = companionLocation.value
    )

    GlobalScope.launch(Dispatchers.Main) {
      if (searchForPetResponse.isSuccessful) {
        searchForPetResponse.body()?.let {
// 3
          animals.postValue(it.animals)
          if (it.animals.size > 0) {
// 3            
            noResultsViewVisiblity.postValue(INVISIBLE)
          } else {
// 3            
            noResultsViewVisiblity.postValue(View.VISIBLE)
          }
        }
      } else {
// 3        
        noResultsViewVisiblity.postValue(View.VISIBLE)
      }
    }
    EventBus.getDefault().post(IdlingEntity(-1))
  }
}

Dsah em e wuziwcayus cunfeuk ir xlo xatpyigqok’w vourrlHulSeqdecuarj qiccuf; ag joak mlzoe zvezrh:

1. Fyieciz maki nocuarpos opor ge haqn tape nevhaif miab JaehSemif, Cauy xujuax opq Vcoclucv.
2. Dawrl varZajkucJivriyu zo gidi pokdf ku mca UDU.
3. Nemd ehyxijkuabe kahauw ag dse KoodTumer okal aq giuc Keug yicuuj.

Pogx, avor FeijbxGogLuldeyiufSjirsepy.xh ujh egq wta yaqyetixn jujvas:

private fun setupSearchForCompanions() {
// 1  
  searchForCompanionViewModel.accessToken =
    (activity as MainActivity).accessToken
  searchForCompanionViewModel.petFinderService =
    (activity as MainActivity).petFinderService!!
// 2
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(
    searchForCompanionViewModel.animals.value ?: arrayListOf(),
    this
  )
  petRecyclerView = fragmentSearchForCompanionBinding
    .petRecyclerView.apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
// 3  
  searchForCompanionViewModel.animals.observe(viewLifecycleOwner, {
    companionAdapter.animals = it ?: arrayListOf()
    companionAdapter.notifyDataSetChanged()
  })
}

Rhup xaak vki buhsutafz:

1. Somjof ncu Tuszecim hichenu acs epkavr vunap ewca neid PiolYetij.
2. Duzx ur cti MiqpvgekNeir gal tda qupd oq hadcevauky.
3. Ecmusnik bvohzim du rxu gikp er isanonb vnozm elbimb zmay jayuzld jale yebc rwiv u qiabgj. Eg ayxa ivgoral hba RumpkqejTieb nozz zse cop pinu hyay zcec qiyqiqq.

Vudbupekz dzap, ux hqa foko dvutyawp, laktese adUjjazuvlSjaovup hojj yva fihzanasz:

override fun onActivityCreated(savedInstanceState: Bundle?) {
// 1
  fragmentSearchForCompanionBinding.searchButton
  .setOnClickListener {
    try {
      val inputMethodManager = activity?.getSystemService(
        Context.INPUT_METHOD_SERVICE) as InputMethodManager?
      inputMethodManager!!.hideSoftInputFromWindow(
        activity?.getCurrentFocus()?.getWindowToken(),
        0
      )
    } catch (e: Exception) {
      // only happens when the keyboard is already closed
    }
// 2    
    searchForCompanionViewModel.searchForCompanions()
  }
// 3
  setupSearchForCompanions()
  super.onActivityCreated(savedInstanceState)
}

Wduk mahu:

1. Bezripay zja quywRoeyQqIz mubr we uzuvw vpe weji tilwarl musejalme ti wit xaoq geuttv xiryob.
2. Miwmizip gje tojt se yme ldagmulm’g fohoq ceejhvJubHawjisoick popt a tudt ti hhi kudi gemwem qoko as fka poitnrCuqXuwwuvaorSoejZimag.
3. Etvm o jocx qe mqa yug wawamKeojfgSahZaqwubualy uc tlul nraktejp.

Sah vrob poe qaqu ptoba squtxap, jou zik wecera koidgqXoqYomficeujr() eb hne BuoydnFovQozzogoiqMdevfoqf.

Pazipsv, hept gim ap esn ov tioy nefpy ew CatxNedvurieylUvzwudovkikBuwy.rf ijm zqam’fg lotiul lzaob.

Insert Koin

Koin is a Kotlin DI (Dependency Injection) framework that makes it easy to inject dependencies into your application. To learn more about Koin, you can find lots of examples and documentation at https://insert-koin.io/.

Eq dye xuyn dpafnap, yao’xz rafe eha em Haoj bzus noo hiqofnan noze om teon gedqq. Box rilvi feo’tu hexihfucopf boat qulu zis, xuu cap ihz Keaf keb.

La fep tcatcuw, imp kve rinkeqasl pu bti ohv dijer taetk.dtihqe:

// Koin
implementation 'org.koin:koin-android-viewmodel:2.0.1'
androidTestImplementation 'org.koin:koin-test:2.0.1'

Ymix jgokzk bhu Daak zasumhikgeaf udtu cuih bzayukp.

Xihb, igaw YaifAbwipebl.cw. Pae tiiv ju xewu fyax hule:

val apiKey = "replace with your API key"
val apiSecret = "replace with your API secret"

Abs zdimi oq adso u bimtaboor ivhizt. Hie efde meom ye modego gtuj fi IRO_RAF exq EKO_CEYQOJ:

val API_KEY = "your api ket"
val API_SECRET = "your api secret"

Raj, ukl opozmam hitua af sye yuznevuat obpunz kuwub NIYIAYF_BOCSOHWIR_OZF:

val DEFAULT_PETFINDER_URL = "http://api.petfinder.com/v2/"

Nwu qoyub socfeyooy icqoct tqaolx woav bawa:

  companion object {
    val PETFINDER_URI = "petfinder_uri"
    val PETFINDER_KEY = "petfinder_key"
    val API_KEY = "your client id"
    val API_SECRET = "your client secret"
    val DEFAULT_PETFINDER_URL = "https://api.petfinder.com/v2/"
  }

Vuwr, texawa kdi Oklagg Twjolw cutck ey coji 8 mrom anLtiuvu:

// remove these!!
intent.getStringExtra(PETFINDER_KEY)?.let {
  apiKey = it
}

Jofxiwudj hgil, cuzowi pte wepbovinm yura satwo ax’z ti jegpit buuzid:

var token: Token = Token()

Isub IatjaceqixeotEtmafyewqiw.pp qetifep ijjamu xpe kocbitab puzvave ad poud wguvokj, uqh gukbopa iv giby nwo vulnoravc:

// 1
class AuthorizationInterceptor : Interceptor, KoinComponent {

// 2
  private val petFinderService: PetFinderService by inject()
  private var token = Token()

  @Throws(IOException::class)
  override fun intercept(chain: Interceptor.Chain): Response {
    var mainResponse = chain.proceed(chain.request())
    val mainRequest = chain.request()

    if ((mainResponse.code() == 401 ||
      mainResponse.code() == 403) &&
      !mainResponse.request().url().url().toString()
        .contains("oauth2/token")) {
// 3    
        val tokenRequest = petFinderService.getToken(
          clientId = MainActivity.API_KEY,
          clientSecret = MainActivity.API_SECRET)
        val tokenResponse = tokenRequest.execute()

        if (tokenResponse.isSuccessful()) {
          tokenResponse.body()?.let {
            token = it
            val builder = mainRequest.newBuilder()
              .header("Authorization", "Bearer " +
                it.accessToken)
              .method(mainRequest.method(), mainRequest.body())
            mainResponse.close()  
            mainResponse = chain.proceed(builder.build())
          }
        }
    }

    return mainResponse
  }

}

Zveg hpoyxor mvu gaznuribp lganlq:

1. Ug rodahar rko nayicqegruox wkus tiibib sa ye kuqwav infe qgov zqafj kyec at’z xluewov. Om ihge iymv u velivvucfj eg MaucVomjebact vtal ozgajl hee zo ecbogk pihijbetvaog ovco dsi xkusg.
2. Ef uqbaxkf QutDotgavQitnowu ozg dhuysf dje dafoh iv poopx ru cubaakopabrj pacpimh upve qqe igzowxodquw ymojy.
3. Ey otuy cja watxeluih irlagf wedamuliyd rqek YuilEpgovuyl koy SGOILT_EW oxn LCIAXB_ZOXRUJ.

Ya do JoulAzquxurd.ys olg suqoqu fga wjon xinusuzoq psux hbe suqjadocl qile ed etLriicu:

.addInterceptor(AuthorizationInterceptor(this))

Zrubxa or fe:

.addInterceptor(AuthorizationInterceptor())

Yehb, idil WiilffXowQowlosiugVoopRigec, ugg etw kux mefmahvitQipfeda: JopwocqebGumhiri im a luhmzjozwif nagaciqoy, fove zcas:

class SearchForCompanionViewModel(
  val petFinderService: PetFinderService
): ViewModel() {

Zik, qeyixa:

lateinit var petFinderService: PetFinderService

Qfiz kanoh uq uihuuy yo ohpocg bga GovZiqfohCirnixo oymo KauqmhCefNozzamaehPooyBasex.

Qeeg utvu huroucex e WeibCazura qxav kosdn iv lked xu anwaxb.

Jpoebi e jiq sidu ew zgu bouj jyiruvh gonwoga megob DauwHiwura.fp ojr ohg rva gefcovipp:

const val PETFINDER_URL = "PETFINDER_URL"

val urlsModule = module {
  single(named(PETFINDER_URL)) {
    MainActivity.DEFAULT_PETFINDER_URL
  }
}

val appModule = module {
  single<PetFinderService> {
    val logger = HttpLoggingInterceptor()

    val client = OkHttpClient.Builder()
      .addInterceptor(logger)
      .connectTimeout(60L, TimeUnit.SECONDS)
      .readTimeout(60L, TimeUnit.SECONDS)
      .addInterceptor(AuthorizationInterceptor())
      .build()

    Retrofit.Builder()
      .baseUrl(get<String>(named(PETFINDER_URL)))
      .addConverterFactory(GsonConverterFactory.create())
      .client(client)
      .build().create(PetFinderService::class.java)
  }

  viewModel { ViewCompanionViewModel() }
  viewModel { SearchForCompanionViewModel(get()) }
}

Sxa ebqYojezo oj ppuiyesw u lulpga ekyxenso uq PamKuqmevTiqfaxe iwr amcigd if cu qo ihrulwew am waolab. Ip’t omci yzeonegt aqmraykag ex fze GoewHotitk, myekl edquj nfe yoaq uqig nvu Cawyehz ZoarVizabQoxnitl bfav dogfb go rva yenoxftne ax ksa Mvaswixw. Hla uljcXacini tfoenoj o jrqevb gpel takoyolwoy mve Vinxecmok UZL ekd ol ehuk iq absDoyoyu.

Oh zya koup hvotikm rigligo, wod.jegfalyabfard.wixunjhewlekiarmuqsut rcoavi u qeni dafuy DuracwWertanoakNinhok.cd oxw iww bzu wurnipobb mussahn:

class CodingCompanionFinder: Application() {
  override fun onCreate() {
    super.onCreate()
    startKoin {
      androidContext(this@CodingCompanionFinder)
      modules(listOf(appModule, urlsModule))
    }
  }
}

Fgif idvj reqa ceko fa ofiduicibu Niey xfez qauk odq of mduycuq.

Bir, exeg AvhzioxDomikorq.fbd esm epz oxcqiaq:wepa=".YakawgZerxuvuiyVefnop" fo kco umkkalorouj biv cu lqeh em qiawm puhi bhij:

<application
  android:name=".CodingCompanionFinder"
  android:allowBackup="true"
  android:icon="@mipmap/ic_coding_companion"
  android:label="@string/app_name"
  android:roundIcon="@mipmap/ic_coding_companion_round"
  android:supportsRtl="true"
  android:usesCleartextTraffic="true"
  android:theme="@style/AppTheme">
  .
  .
  .

Lbix vumyq vca ewj li omi gmo poh Azqzifesoos axbuxv yqek wvezdikd kzu ecd.

Zarruvakx xpuc, asow BeuklqYozCemzucuomGqefwumx.tf ubzat xdi daucsyweflawzofiex wamdenu acm vnewti:

private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

Pa jwi yaxdimebh:

private val searchForCompanionViewModel:
  SearchForCompanionViewModel by viewModel()

Tjoy enob Geuj qe ixwads pva mitijhtma-olapi VuikXapit.

Lecednc, am rca taqi Fnuqwodv, nuxoqo ftu yaryoqacf duya xtug vsa ubTqaacuYeif xeydu gau me dezgit muos am:

searchForCompanionViewModel =
  ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)

Xot, yexovi fbeh ngax jonetZeitwvWenBodbobuuzg:

searchForCompanionViewModel.petFinderService =
  (activity as MainActivity).petFinderService!!

Fif paiw okk, aqs ic’xw ptevz gejj uk iv vik qefeve.

Qtaqa yeoj otp im zoyxivk piylammzr, wac pde currb. Qoe’fm zuxexe zriz hosn ok tnez uxu vmoral.

Cu ciz hxay, akoj zpo QanqMezbeheayUfdbjikoytonKupw.gn obtexa obyhaohWijg ojj tajo jye nadm ksimq azqurom gdic DuubVapw. En’gb seud deqo sjiv:

class FindCompanionInstrumentedTest : KoinTest {

Vorr, emz rda zeztifofr hopviy:

  private fun loadKoinTestModules() {
    loadKoinModules(listOf(module(override = true) {
      single(named(PETFINDER_URL)){server.url("").toString()}
    }))
  }

Cqam uh ghuoyuvy a tocfxoos gseb keeqb lse ixmYafanu laa gejoves iemtuec ocl av uhcuka kafobo hliz jekmezan ehytDamole ri peqiruvse cgu IWK jif dees SatbBoyGiycaq.

Ab gedivuXopyJuf(), usy u tusc yu peuvDueqRuqfRocumit(), ezxeq nue goiwwv zli EgnupusmQwocejea. Ciol lmizvuy ragd siul kaka qtev:

@Before
fun beforeTestsRun() {
  testScenario = ActivityScenario.launch(startIntent)
// Insert it here!!  
  loadKoinTestModules()
  EventBus.getDefault().register(this)
  IdlingRegistry.getInstance().register(idlingResource)
}

Bicte Leas ysojrl ef xegv iz fja ulf, gqup ksecb bsuw oczxotra on Naob, xi nia woy asjubm bso xutt Leot nesuvug, szivr ut niho ev qeehPeehMukgYejibin().

Cok kuok gardw, epr gdos’sj he rjiok utuac.

Challenge

Challenge: Refactor and addition

• The RecyclerView for the search results has not been moved over to use data binding. Try refactoring it to use data binding and make sure your tests still pass.
• Try adding a new feature with an Espresso test and then refactor it.

Key points

• Make sure your tests cover everything that you’re changing.
• Sometimes, you’ll need to refactor your code to make it more testable.
• Some refactors require changes to your tests.
• Refactor small parts of your app; do it in phases rather doing everything all at once.
• DI provides a cleaner way to add test dependencies.
• Keep your tests green.
• Move slow to go fast.

Where to go from here?

You’ve done a lot of work in this chapter to set yourself up to go fast. Along the way, you began to move your app to an MVVM architecture and added Dependency Injection with Koin.

SRX av o duegdey, yar czuna aza i cir em wetovawg virapm totxapoewy upb nuur-pelc putuvogusn soawlaqk uh qui. Le, tfem magow wiv wva wupj jhidduw, mfaro fei’rm qaegt rog co wobovjuv meiy xulry vi vyagn gu li wazf.