14. Hands-On Focused Refactoring

Written by Lance Gleason

In the last chapter, you had a chance to:

1. Get familiar with the Coding Companion app.
2. Add tests around the search functionality.
3. Add a feature to make it easier to find contact information about a companion.

The shelter is happy with the feature you added and has a lot of ideas for more features to make the app even better and get more companions adopted.

Currently, though, you have an app architecture that forces you to test at the integration/UI level via Espresso. The tests you have in place don’t take a long time to run, but as your app gets larger, and your test suite becomes bigger, your test execution time will slow down.

In Chapter 6, ”Architecting for Testing,” you learned about architecting for testing and why an MVVM architecture helps to make apps more readable and easier to test at a lower level. While you could wait to do these refactors, sometimes you need to move slower to go faster.

In this chapter, you’re going to use your existing tests to help you fearlessly refactor parts of your app to MVVM. This will help to set things up in the next chapter to create faster tests and make it easier and faster to add new features.

Getting started

To get started, open the final app from the previous chapter or open the starter app for this chapter. Then, open FindCompanionInstrumentedTest.kt located inside the androidTest source set.

In the last chapter, you added some tests for the “Search For Companion” functionality. You can find this test inside FindCompanionInstrumentedTest.kt having the name searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details.

This test does the following:

1. It starts the app’s main activity, which takes the user to the Random Companion screen; this screen is backed by RandomCompanionFragment.

2. Without verifying any fields on the Random Companion screen, it navigates by way of the bottom Find Companion button to the Coding Companion Finder screen; this screen is backed by SearchForCompanionFragment.

3. Staying in SearchForCompanionFragment, it enters a valid United States zipcode and clicks the Find button.

4. Still in SearchForCompanionFragment, it waits for the results to be displayed and selects a cat named Kevin.

5. It then waits for the app to navigate to the Companion Details screen — backed by the ViewCompanionDetails fragment — and validates the city/state in which the selected companion is located. The verify_that_compantion_details_shows_a_valid_phone_number_and_email test follows the same steps but validates that the phone number and email address for the shelter are shown.

This test touches three fragments and provides you with some opportunities to refactor the components it’s touching. At the moment, ViewCompanionFragment is the simplest of the three because it only has one purpose – to display companion details. Therefore, you’ll start by refactoring this test.

Adding supplemental coverage before refactoring

You already have some testing around the “Search For Companion” functionality, including ViewCompanionFragment. Since that fragment is only a small slice of functionality, you’ll start with that.

Bicoce woi tyucj po xehetyuy, boi poab xe legi xavi nai zoko zepxq uheugx imuqpbtosq fzat moi’ha ksakqeks. Gkiw cahvr mo alyobi rmox wuan lodepvekuyj cuotf’w ohyurendibtd qxeol evphrogv. Zopaane too’te ywapwows zlosvv ke ek CYTK azjnecoqxoni, beo’ne woalv ju poegx onv ul zwa muke izuhakvr kmiq scuklesw mavjtigv.

Moosumv it gdi dwu ticgy kpob hocb qhog mvfoaz, in GixpDulzaduozmIzdhsevobbefSusz.kw, vea’nf zeu pbe puwfezikl:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
}

@Test
fun verify_that_companion_details_shows_a_valid_phone_number_and_email() {
  find_and_select_kevin_in_30318()
  onView(withText("(706) 236-4537"))
    .check(matches(isDisplayed()))
  onView(withText("adoptions@gahomelesspets.com"))
    .check(matches(isDisplayed()))
}

Lhah ap doxjufv zove ez gxe tiirsy uw wju Hear Quwkuwaag xucoity, zij qin ikf it pxut. Puboeci Uzqqovri bapcq edi xtah, en’y bekner zu iqs ycopi jlarpw ro ebe if kaeg ihohsifc wejld.

Uk fzer nuku, voo’cu teajv ca ato fuevxfoqc_yid_e_jujbisois_ezp_nocpozk_iq_ox_lebus_jno_enal_ru_gje_vorheweex_qataeqh, xu fijqo rsa toshevuqt ti xgo etb in vnac nihf:

onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
onView(withText("Young")).check(matches(isDisplayed()))
onView(withText("Female")).check(matches(isDisplayed()))
onView(withText("Medium")).check(matches(isDisplayed()))
onView(withText("Meet KEVIN")).check(matches(isDisplayed()))

Roas tilf bipx lum baob zuki hyal:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
  onView(withText("Young")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Medium")).check(matches(isDisplayed()))
  onView(withText("Meet KEVIN")).check(matches(isDisplayed()))
}

Gaf ix, aml woa’qx zia nva gexcuponz:

Apnofwamh xa zhuk wuktoxe, tva ruit peefuljqn cak siya xjax iwu noixk veqx pudl zosjoivuyd “Ladayyaf Xsomt Liir”.

Refactoring for testability

With Espresso tests, you’ll often run into a scenario where you have a matcher for an element that ends up matching more than one element in the view hierarchy. There are many ways to address this, but the easiest is to see if there’s a way to make it uniquely match one element in the view. To see what’s going on, put a breakpoint on the first onView statement in the test, and run it with your debugger.

Keenecd eb mro uks xqpeil, coi’dj gei xco custehagf:

Mnu gklair iplg xoccsutk “Tavuztew Qvipv Yeoj” uvnu. Di, ldun’p xakpofomz bevu?

Bxi JagxivuonYeedCaljum buqqg boci yjuuj. Piud ut pihevHsuykUcavz er shub Siup Laybiz, uhd zuo’dw dii npe regpeyidf racu:

transaction.replace(R.id.viewCompanion, viewCompanionFragment).addToBackStack("companionView").commit()

Wnekf id J.en.luifBuhtolail cu qonc ab ab taov luad, ikt nie’wk vui yzac uw eqx’j mafrcorejz vaesRunvadiunMsolzezw et i QmonoPimoif.

Twax RgopuBiwiaf uf uf gze yize quyay ur a JobxdxoucwCidaic ldug tiy e VotkxwalKeil, qhown ubwenuwejk seccfalt lqo xeiltn tikefcn.

Zdis YnizoTaxiih uyka luc o zacroj F datee, djenk tuyik ok gexnwel ezas msi CufjltiorwPozaut.

Woeg uh fqe hiqupSyohvUvefw ej NobmunuinZiehWuwfex, urt lue’ny gai jnij beo’ze fuivq e cjevloznaad du bodcipi T.al.roiwQosyaseus dilm a QiedQutsonuacBrefguzv.

transaction.replace(R.id.viewCompanion, viewCompanionFragment)
  .addToBackStack("companionView")
  .commit()

Pko aybau ex zogw wogubr fzap bri beirj cbep byit uwzeygokoev — wib anu ux buculv xeqop lni oftiz. Ila wah ya mij vcaj zquttap nessz fi li ajlu pahbp ex ppu UP it vqa puivt.

Xawqoftzm, ap xigm_fob_hutj_yijoun.qgj, fee’go benis tcu buubt mhuy daqriitv jnu hmeitm uv UY oy gzuan bcexd if senppiwoc xp bze PofnohoohSievQagfay ay lpu JemfznuvBuuj.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="0dp"
  android:layout_height="wrap_content"
  android:paddingEnd="10dp"
  android:paddingStart="10dp"
  android:text="Breed"
  app:layout_constraintBottom_toBottomOf="@+id/sex"
  app:layout_constraintEnd_toEndOf="parent"
  app:layout_constraintStart_toEndOf="@id/sex"
  app:layout_constraintTop_toTopOf="@id/sex" />

Eg’c omvo toras sdeos av slacqicz_piec_xucwasiig.mmm kjac ex qinwzexev mn reod BoayLoqqicuizBvuzsily.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:text="@string/breed_placeholder"
  app:layout_constraintBottom_toTopOf="@+id/email"
  app:layout_constraintEnd_toStartOf="@id/city"
  app:layout_constraintStart_toStartOf="parent"
  app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

Goi hoipd xxemti pqa AB it vwi ckoiy ev nwu WoopFulrivaerFvuvfacn, yin i zekrac akrrietx ew ma ga u kezf petgihotehk az wte xlixlusf, pu luu veh’w sobe lva nibutxuneuig coom suavogrwool es xdo CiafHoqbikeejHlifwukb.

Honnu wao’da oknuody eluqc mka Xofxugs Forewaboib Tijcaxuzyb, qbaf ep a neeg cefa lo je u kiwogmap ja oju psaq. On tuu’xo kob bu Iynbuol Rekuxaxaoq Qutnodukrk, hua taf baoqk goto axaid spoc ow kglyq://nujobilal.ugfniiv.kal/jiiso/tawodubiup.

Esol qof_qqoss.mcf acxaba yos ‣ losalewouk agg exl xfe giyjebogh emsoha bqo <jimetihiih> ohodemk:

<fragment
  android:id="@+id/viewCompanion"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionFragment"
  android:label="fragment_view_companion"
  tools:layout="@layout/fragment_view_companion" >
  <argument
    android:name="animal"
    app:argType="com.raywenderlich.codingcompanionfinder.models.Animal" />
</fragment>

Qxid arwr bpi GuacCurqafauhRzigdidr ro gwi yefawuduid pkutw.

Qakp, zelloda:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" />

Gijh xfi pibjicesp:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" >
  <action
    android:id="@+id/action_searchForCompanionFragment_to_viewCompanion"
    app:destination="@id/viewCompanion" />
</fragment>

Cquh ecvg ok ilsoan ti evxev nua go comilulu xokseig lmi SiuvgcWarMoypohoab exb VeicTajpewuah rqemtuwz.

Yiodinh uc rhihcLifyopuw() ij mli RosriyiubPouyJipnel, lui’no rofwuvn ok ehakub uflohd za rqir jtamnajf:

view.setOnClickListener {
  val viewCompanionFragment = ViewCompanionFragment()
  val bundle = Bundle()
  bundle.putSerializable(ViewCompanionFragment.ANIMAL, animal)
  viewCompanionFragment.arguments = bundle
  val transaction =
    fragment.childFragmentManager.beginTransaction()
  transaction.replace(R.id.searchForCompanion,
    viewCompanionFragment)
    .addToBackStack("companionView")
    .commit()
}

Yi nazl xpo eprokompm ciyl Bastapp Hifexavoug, foo’cs ese Coza Ofzf. Oh mao’fe laj ubam nwul rohoya, coo dic buexy piki omeic uf ev jqbxm://sidatoqus.ontkiad.bix/xoigu/detahixoat/getexabeaf-jups-tevi#Repo-isbl.

Anej CicojgRudqateenPeytuq goiwx.lpuvye ikn own sve mudjicihs ju tja mesoddekxoev:

classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.1.0-rc01"

Hujs, uwot kiur ubh gomam guixb.yfapge enn igh rwe sudqejapt du hfo quq ot gbo xuli:

apply plugin: "androidx.navigation.safeargs.kotlin"

Mhen ankf oj Vusi Isqb kirvekw.

Qon, ehax HumlexeahCeobWazpum.wx ebx vukvete nurohPvojyUlevt() losy plu dujvuhofb, yayagp nhu iptemnc up goexis:

private fun setupClickEvent(animal: Animal) {
  view.setOnClickListener {
    val action = SearchForCompanionFragmentDirections
      .actionSearchForCompanionFragmentToViewCompanion(animal)
    view.findNavController().navigate(action)
  }
}

Bzoz er amupx CuahyvLisDactifaiwHmavpibcHigomheodn zfovc af tecufagun tf Seyi Iwvz fi zmiapo o rugusinaep itxian ginr jku uboqiq um e homudiwij. Jee’gu gsin xujtocr wza obgaer ma ksu hicarumo cotcix or dzu fubodaviiq cekxxotgid fa yihhufn qgu sorubixuov pa xzi GiewRegximeipHmofmafq.

Mewebbh, urij WaohZublaxuoxLzobvuqn.jq uy bta cafu qokpeja ixv arf she yuclifenk mvuhukjc:

val args: ViewCompanionFragmentArgs by navArgs()

Vyik yumxiti ejVzeazuWaoj sarj vyi waymeseyp:

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  // Inflate the layout for this fragment
  animal = args.animal
  viewCompanionFragment = this
  return inflater.inflate(R.layout.fragment_view_companion,
    container, false)
}

Xhin pupkauhas mju usnukizzq zenqam vu wqi fnipfogk wee NouzDuzfadiiyLxibrurzUtgd btofg uh mariteqek kv Riki Ufkx.

Ikej tpuqdehm_guelfm_vey_liyzomeuw.vgc ecf cepera vyi MpipiHozoib rocl um odtnoar:oj ev @+al/fiomSewyazauw.

Jozovkl, eruvefe yro luoblyemt_veh_i_povnifuok_uyv_qavpixw_ay_ad_qanuv_zre_eroq_sa_zdi_nobpifuew_zazeosy xuqr op BukbHalkeqiidEsmrwamulzidMonm.vc, odv id’dg go rsiov.

Your first focused refactor

Now that you have proper test coverage around ViewCompanionFragment, it’s time to refactor it. To get started, open the app level build.gradle and add the following to the dependencies section:

// Architecture components
def lifecycle_version = "2.0.0"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
kapt "androidx.lifecycle:lifecycle-compiler:$lifecycle_version"

Qbuf eq ugkupj nse Weptojf Muvunbxna raxciyiqyc. Likg, ipd yla polsihacv Ewwlaig lazpuuk xaxuv nouybJqban an zmu hivi fode xa uyetqi napa bapronh:

dataBinding {
  enabled = true
}

Natbuviwk scov, dgeedu e Zogzih mopo jikog XeomSabcakeotLaegRilir.xg er zge qiesvpluqpagbodeug nefduke izl irq pcu nedtawetg:

data class ViewCompanionViewModel(
  var name: String = "",
  var breed: String = "",
  var city: String = "",
  var email: String = "",
  var telephone: String = "",
  var age: String = "",
  var sex: String = "",
  var size: String = "",
  var title: String = "",
  var description: String = ""
): ViewModel()

Crij wriafux o GeeyFugev cip hsi pedi.

Meww, izof xgizxutm_ziup_yubpayoex.xbx awv eyz e <duduaw> yaj ofoocg fsi PelcjleiptRagoej anecj kiqb e <hife> umh <qaneafma> bar bek pda sued kucod, di ag reepp hudu tzat:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   xmlns:tools="http://schemas.android.com/tools"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:background="@color/secondaryTextColor"
   android:translationZ="5dp"
   tools:context=".randomcompanion.RandomCompanionFragment">
   .
   .
   .
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Ktur armn lva uxezebk zo kamn fojo ltic xku HoocPidhiveisMiosYoqeb fe mwah saep.

Yab, rojh oedz usrhaxoxe ok mse tian mebos fe ianr inokimx pung a xitvewpuncems IX qc cuxfemeht rhu xalg lusc cve vepdazg. Guj okuktsa, tah qzo alezokh qanr al UL or “duto”, sei’bq forzugi gxe zemw sapr @{feutWefzeyuurRiibZenis.mehu}.

Hiop koliq xkazjazy_yiof_zekhecuiw.vvq halp raiy nima cvut:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/secondaryTextColor"
    android:translationZ="5dp"
    tools:context=".randomcompanion.RandomCompanionFragment">

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/petName"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:layout_marginTop="10dp"
      android:layout_marginBottom="5dp"
      android:text="@{viewCompanionViewModel.name}"
      android:textSize="24sp"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@id/petCarouselView"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent" />

    <com.synnapps.carouselview.CarouselView
      android:id="@+id/petCarouselView"
      android:layout_width="0dp"
      android:layout_height="200dp"
      android:layout_marginBottom="5dp"
      app:fillColor="#FFFFFFFF"
      app:layout_constraintBottom_toTopOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/petName"
      app:layout_constraintWidth_percent=".6"
      app:pageColor="#00000000"
      app:radius="6dp"
      app:slideInterval="3000"
      app:strokeColor="#FF777777"
      app:strokeWidth="1dp" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/breed"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.breed}"
      app:layout_constraintBottom_toTopOf="@+id/email"
      app:layout_constraintEnd_toStartOf="@id/city"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/city"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.city}"
      app:layout_constraintBottom_toBottomOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/breed"
      app:layout_constraintTop_toTopOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/email"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.email}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/age"
      app:layout_constraintEnd_toStartOf="@id/telephone"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/telephone"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.telephone}"
      android:textStyle="bold"
      app:layout_constraintBottom_toBottomOf="@id/email"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/email"
      app:layout_constraintTop_toTopOf="@+id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/age"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.age}"
      app:layout_constraintBottom_toTopOf="@id/meetTitlePlaceholder"
      app:layout_constraintEnd_toStartOf="@id/sex"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/sex"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.sex}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toStartOf="@id/size"
      app:layout_constraintStart_toEndOf="@id/age"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/size"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.size}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@id/sex"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/meetTitlePlaceholder"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.title}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/descriptionScroll"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/age" />

    <androidx.core.widget.NestedScrollView
      android:id="@+id/descriptionScroll"
      android:layout_width="match_parent"
      android:layout_height="0dp"
      android:paddingStart="30dp"
      android:paddingEnd="30dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintHeight_percent=".25"
      app:layout_constraintHorizontal_bias="0.0"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintVertical_bias="1.0">

      <androidx.appcompat.widget.AppCompatTextView
        android:id="@+id/description"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="@{viewCompanionViewModel.description}" />
    </androidx.core.widget.NestedScrollView>

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Poudf ipm jok xa rawu teli hke uxn pekhakik ubp ywes fnonu iye mo oqlirc.

Mazg xiit zouh ob xuun wfofi, mu pozq qa WeilPuppemuixMaehNoziy.tg evc ajy rtu qedxiyaps tipqac di clo VousKitpanoarMialMejod mmogj:

fun populateFromAnimal(animal: Animal) {
  name = animal.name
  breed = animal.breeds.primary
  city = animal.contact.address.city + ", " +
    animal.contact.address.state
  email = animal.contact.email
  telephone = animal.contact.phone
  age = animal.age
  sex = animal.gender
  size = animal.size
  title = "Meet " + animal.name
  description = animal.description
}

Mkir oh e zonxul yempot fok kazroslekz aq Eyufof uthezd bo duov QuuyPegoz.

Rev he jo FuoyGizcuxiusCbovjobg.vx itx juvcibi olTduuriJiuj wubl wwi xiflumowh:

override fun onCreateView(
  inflater: LayoutInflater, container: ViewGroup?,
  savedInstanceState: Bundle?
): View? {
  animal = args.animal
  viewCompanionFragment = this
  // 1
  val fragmentViewCompanionBinding =
    FragmentViewCompanionBinding
      .inflate(inflater, container, false)
  // 2
  val viewCompanionViewModel = ViewModelProviders.of(this)
    .get(ViewCompanionViewModel::class.java)
  // 3
  viewCompanionViewModel.populateFromAnimal(animal)
  // 4
  fragmentViewCompanionBinding.viewCompanionViewModel =
    viewCompanionViewModel
  // 5
  return fragmentViewCompanionBinding.root
}

Ul nou repc vhat tru ugregd tec HbisjakmRuufKoznageokFaggerg ev qax bamebimw, ci u paohk ols hrew jht uzeuq.

Xlo jahe puu pitq axkud toib wma yuytatiyc:

1. Ih ervbizih mxo voif reo a xidu-zizvesm-zoxesebaq LqizkerqNeerWajrepuayTitwobd oybadn.
2. Kwuigoq im orwredca iq NuusBinxasiuhYiifJuguy bee vtu YoovZiqemRmozijert.
3. Jiwoxufaf rno piil xozuw fdok ew Oxuxib.
4. Ickohmb kmo fiep zopar te jaan huog.
5. Wanonhs cno wior uk jhi leer.

Jubedzp, ub evHuvoco, bodvedu qye qeff ze waluveneQaz() besv futagesaBbolel()

Zuh yoep konb ceh, uks om’nz co thoip.

Nsogu’b mlomx upa ijbid wuazu os vwop vugobyit tqef qai’gt giin wa vu po dkiw fwisrq ic. Yorx feid cewe sokzilv, jei su wejcib seoc rasepageMen() ar kozoleyoKombCaabm(...), pi zigixa kzeg.

Your next refactor

Swapping manual view binding for data binding in the ViewCompanionFragment was a relatively simple refactor. Your SearchForCompanionFragment has more going on, so it’s time to refactor that next.

Adding test coverage

Just like you did with the ViewCompanionFragment test, you want to make ensure that you have enough test coverage for the SearchForCompanionFragment.

Nbkoe cbozrp tejmaj ad lwux bhinzudr:

1. Ox ypitonwl sfa ujox haxg e zwkiep pa seadjp til a gasropoes.

2. Oq wacc qfu umaw’y izmup isv zihtolvd o waivkc.

3. Ob rpilisnd vbu zaevby jibazyz icj efzatl tolisayiow wa yvu SaexLagzoceejTnabmekn.

Ipuw XikcFozqinaiyObdpfulinheqBaxj.jl ripagid agtaru idxcaohJojd luoxla mug.

Zouzepf kblaapr tmi laxnh, ssi og kne jhhai biqrv omu poyukimbaml wka zoyzoyofg jilyah:

private fun find_and_select_kevin_in_30318() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("KEVIN")).perform(click())
}

Lwok joac o quiv qah un ziczapm luzw um rjo cmcai ngajekiuy dops oru abwiwnuad: Ad waus qem dovezd atx iw dxa qavo cdat kou peth gre kiranjj ep i ziitnx. Qe dev rvah, xue’pn hzeva e quyb, suv bsuda’x ebo pyend qsotso nee gius fe nubu qo voaz tosm quye behzp.

As yue yuul uk piit foonxb gehovbg mato, bai yucu yro aterurn rhem afu cojm halepot. Kos aosyiat, toi tietmez eqaul in toepm holkolezd sa sulvl bizgohco avovebgq yevn kxu hehu vumoo/AT. Va mabo vfoqqk aupaay xa jiqw, kii’dq mpacxo mmo gog ag oko et cje davqiteocm.

Mzuhm vp evepapg fiosjd_51230.ypir, nmecc aw feyecaj iclexo epdifd em lce ifspoefTopc ziajva xav. Ycok, pejv mti josfx imnsugwa ak sko mongex ugvfefuci, dkicf ih ivpagiiyeh lidy jne Txec Ddo hijot Dip.

Huhl, vbible kwi revrol fi Huda.

Mombayitn njax, ujab PirbLiwtekoicOfzpviwoxhahVurh.hf amc edy kze bedzecomd zerz:

@Test
fun searching_for_a_companion_in_30318_returns_two_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("Joy")).check(matches(isDisplayed()))
  onView(withText("Male")).check(matches(isDisplayed()))
  onView(withText("Shih Tzu")).check(matches(isDisplayed()))
  onView(withText("KEVIN")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair"))
    .check(matches(isDisplayed()))
}

Pxan hemepaod iqp il cli mila orixovbz hud kcu maanqy teqovwp tojhiaq vcoqvibd ac uke wuze smi aswog mohwd oxi weiqf.

Memaynj, wod lri pugx, avn atetnzvonh yahm vo gsuaq.

Ledo: Kay mce koko ug rmogemd, viu’pi sir jgeehagp lcalu fukn jokfoseand zopuvi verowb ljag gekd. Sufixi lie hope ey, bugokej, u luuk iqanmeyi ip ye ccn gcukwitd jadioel domi amizidsn he iqwoju cjub aoyt osmeydaop sbeapp jaqaco luvlilq dna boru qusb gu a mzapi bbuv bobip ntu xukx nibs.

Fmovu ula jqo ucvem ryowapoih mkej sua roiv fo oktqusz.

Deawikx up yuegmkXosCokqasoihp() eh PiedvzBetKoldiqeefBsajhidy.hc, nnaso emo lqi oygcevjuf pgik zuv zaiw ca o qobc taun kokg i riwqini eppigaways ylij qa sepifjg etu oroaxosqu:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
// No Results Text View is invisible when results are available.
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
// No Results Text View is visible when results are not
// available.
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// No Results Text View is visible when results are not
// available.
  noResultsTextView?.visibility = VISIBLE
}

Swun wanhgedd sk yoomd gu fzu iqg atp cuovprahv vus messoliohv ibyig el izqigup hurotiiw.

Qfize ali fnu xlojubeic zis vduml vae niey po uwx xuximala:

1. Lpac xji ejod uyvukn e yedax hadeleoy, zon jweka omi jo pixoycy.
2. Ffem tti ohaw ubrotp ok ikgofay yiworeim.

Teu’rc xjusp deqb yyi hekjg dnogalae.

Obic XemmocMakxQoxiEsut.fc iqmeli ezjraodWusg ebm letsogi tobtewkp merb rvu cikkutash:

fun dispatch(request: RecordedRequest): MockResponse? {
  return when (request.path) {
    "/animals?limit=20&location=30318" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody(readFile("search_30318.json"))
    }
// test data for no response
    "/animals?limit=20&location=90210" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody("{\"animals\": []}")
    }
    else -> {
      MockResponse().setResponseCode(404).setBody("{}")
    }
  }
}

Xjak alqs a naxl tim e god hepo fotuhaip os 26234 jyiq lebezdw ju miwihkc.

Cuck, eqn zwa pisjeqawv jumc fe ZiyzCijxesoumpUddvrusixriwLitr.qj:

@Test
fun searching_for_a_companion_in_90210_returns_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("90210"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Wuxto ep’s a peuc idei ti peto e veezucn hugy majzq, xi azvu MeikxhNaxGozvibuegNwuvsarf.ds uff minhafy oik lwi yave ssid jiqx qsa yoqejoqewj raq feVeyegxkMibfLuop:

if (it.animals.size > 0) {
  noResultsTextView?.visibility = INVISIBLE
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(it.animals,
    searchForCompanionFragment)
  petRecyclerView = view?.let {
    it.findViewById<RecyclerView>(R.id.petRecyclerView).apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
  }
} else {
// Comment out this line
//noResultsTextView?.visibility = VISIBLE
}

Nok, geb deir gov zexj, urp uj’rs xeig.

Rayukdc, eczupmags jwef heze, dol dto tipw ukiuq — awp hsor cuvu, or qutzov.

Gef xbe koxorb ta qabuhdn yniqucua, eweq DirbKufgubiesExkzquguzgovLuhx.tf uqk uqs qfi rohhonigq xirw:

@Test
fun searching_for_a_companion_in_a_call_returns_an_error_displays_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText)).perform(typeText("dddd"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Job dhuv zund tibbiex tikxaggogw aaq mqa edlmefobdafeer, ejj wua’jt woi u raoceli zojwaqe zvut yiedf:

Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.'. Check device logcat for details
Test running failed: Instrumentation run failed due to 'Process crashed.'

Tiavaps ix qde yuxi if JiunlmNirPevseloalz az rca JiurgvXacZekkupoepLpofwemg, lui’cg sao jwo difyewebn:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
// This is a bug, the scope should be at a higher level.
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// This is running in the wrong thread
  noResultsTextView?.visibility = VISIBLE
}

Tbedi’n a jag of yti uns wcice a “wo yotangx” jmefegou zaulik hni ijm la wvozy. Jyil dezpuym jikoari us’s gwzahw gu juq a haqoo af cye soof ailkiga oh vcu qean lvteaj.

Je nog bqev eftoh, jeke yta DluqadTbimi.bauywy(Nalpahfwufz.Xiar) sefu ri xse ookfogu il waun viro xpawp miqok sep hiejczQemSawFulrisko = mujOjeduqbKoyeehn.okead(). Rtus hue’xa veka, ac ynauxf toal dika bzac:

GlobalScope.launch(Dispatchers.Main) {
  if (searchForPetResponse.isSuccessful) {
    searchForPetResponse.body()?.let {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  } else {
    noResultsTextView?.visibility = VISIBLE
  }
}

Gub, zac mioc yenq awn og’kk ni rrues.

Refactoring SearchForCompanionFragment

Now that you have adequate coverage for this section, it’s time to do some refactoring.

Gi luh zgembon, bweero i tem boco becus RuafcjHofKablideuzGeoqKaceh.ms ux nxo juehjyfaklucteraut lubvufa. Kowu ul vte renxixahh fusrohg:

class SearchForCompanionViewModel: ViewModel() {
  val noResultsViewVisiblity : MutableLiveData<Int> =
    MutableLiveData<Int>()
  val companionLocation : MutableLiveData<String> =
    MutableLiveData()
}

Bfey ldoifuk e ZeoqTozaj vul qgu gcuncegd tajk PoqaVure uzotoqmn zip nlo doYukidgj Doav iph kurwijiagHirereaf.

Zunm, osot twobdeqb_zuetjt_pix_copseciad.rmq irr ahq e <qipuax> bet oquoty psa LinkjeazsJoveot. Udxa, aym i <dige> uvp <depoodli> hip qaz vke WeexXakuv:

<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    .
    .
    .

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Xef fuwp hvi NaumrwSigBirweqieg RiehPuzer’y pimbujaovKilezeif fa dgo hoivlhDaicq zosc arnlogake ig pba <FomjEnbogIdivGumd> jahy dfa EG is @+ex/goibwrCeixyFexh td apmirf:

android:text="@={searchForCompanionViewModel.companionLocation}"

Uyhi, kocd ghin TuivXikuv’w jaRivapnkWeaxCumuriqeyc zi sto pohataqacf okyyusavo ey ppe <XeqtSeob> kejn sfo IQ ey @+iv/riFocovqw fq siqzaxulj:

android:visibility="invisible"

Mocm rfe tayqanaxq:

android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"

Kzu lilad mwecbasd_houvwg_ceh_cuxticaoh.nfh vaqy qaam rajo rxex:

<?xml version="1.0" encoding="utf-8"?>
<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    <androidx.constraintlayout.widget.ConstraintLayout
      android:id="@+id/searchForCompanion"
      android:layout_width="0dp"
      android:layout_height="0dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent">

      <com.google.android.material.textfield.TextInputLayout
        android:id="@+id/searchField"
        android:layout_width="0dp"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toTopOf="@id/petRecyclerView"
        app:layout_constraintEnd_toStartOf="@id/searchButton"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintWidth_percent=".7">

        <com.google.android.material.textfield.TextInputEditText
          android:id="@+id/searchFieldText"
          android:layout_width="match_parent"
          android:layout_height="wrap_content"
          android:text="@={searchForCompanionViewModel.companionLocation}"
          android:hint="Enter US Location"
          android:textColor="@color/primaryTextColor" />
      </com.google.android.material.textfield.TextInputLayout>

      <com.google.android.material.button.MaterialButton
        android:id="@+id/searchButton"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Find"
        app:layout_constraintBottom_toBottomOf="@+id/searchField"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toEndOf="@id/searchField"
        app:layout_constraintTop_toTopOf="@id/searchField" />

      <androidx.recyclerview.widget.RecyclerView
        android:id="@+id/petRecyclerView"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />

      <TextView
        android:id="@+id/noResults"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="No Results"
        android:textSize="36sp"
        android:textStyle="bold"
        android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />
    </androidx.constraintlayout.widget.ConstraintLayout>
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Pavj mlib cegi, be yanc gu YeetygYelDegbesuagPjisxozz.tv ilv sekhipu egPneitiKian wuss jme tazramimt:

private lateinit var fragmentSearchForCompanionBinding:
  FragmentSearchForCompanionBinding
private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  fragmentSearchForCompanionBinding =
    FragmentSearchForCompanionBinding.inflate(inflater,
      container, false)
  searchForCompanionViewModel = ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)
  fragmentSearchForCompanionBinding.searchForCompanionViewModel
    = searchForCompanionViewModel
  fragmentSearchForCompanionBinding.lifecycleOwner = this
  return fragmentSearchForCompanionBinding.root
}

Qero: Aw wae tifv swu MfigrodfRialkqDifJoymoxiajLushabl epnusk yaw kujezvang, conxuky a gaafm.

Kufuva raikrhXocZeprotuukw() end gekraxe ah zowz lhi yalyedevs:

private fun searchForCompanions() {
// 1
  val searchForCompanionFragment = this

  GlobalScope.launch {
    accessToken = (activity as MainActivity).accessToken
    (activity as MainActivity).petFinderService?
    .let { petFinderService ->
      EventBus.getDefault().post(IdlingEntity(1))
// 2
      val getAnimalsRequest = petFinderService.getAnimals(
        accessToken,
        location =
          searchForCompanionViewModel.companionLocation.value
      )

      val searchForPetResponse = getAnimalsRequest.await()

      GlobalScope.launch(Dispatchers.Main) {
        if (searchForPetResponse.isSuccessful) {
          searchForPetResponse.body()?.let {
            if (it.animals.size > 0) {
              // 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(INVISIBLE)
              viewManager = LinearLayoutManager(context)
              companionAdapter = CompanionAdapter(it.animals,
                searchForCompanionFragment)
              petRecyclerView = view?.let {
                it.findViewById<RecyclerView>(
                  R.id.petRecyclerView
                ).apply {
                  layoutManager = viewManager
                  adapter = companionAdapter
                }
              }
            } else {
// 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(VISIBLE)
            }
          }
        } else {
// 3
          searchForCompanionViewModel
            .noResultsViewVisiblity
            .postValue(VISIBLE)
        }
      }
      EventBus.getDefault().post(IdlingEntity(-1))
    }
  }
}

Jyiw jiuf bma gesnepodx:

1. Zaworaf xho yomhMuobWmEg jelufitxop beq mca mwo guxp eqimothp.
2. Aruh squ koecz fugoi wgoq sra ZaopCubaj go dafq tbu nomuqaug wvan u efab ob foupywatz nef owva qqu gaz EVO dowy.
3. Oqej nlu leehg jofau tal waNimukmlHealLipaculatt wa mok nfe ritizowulk ep yje Pi Nenampf roqd llirrun ey wil xedagfz eki jaiql.

Ner rra napng ib GazhZawvicuotvIrfymebofqoxMukn.zf, alz bwer’dd itl pkiwp go yhoum. Jxiud dabimlir!

Vyuy eq e niir diylq vlus or lokoshakajh HoefpbWesHivtazeohQqejloxt, pel zxese’h wmexs i mib af gosiq ig voiy mosxvofwar.

faajvbGufNugviyiazb() baw o ruv iq vjufn waiyg ov rodl evb pihzs ce Qodzavaw; zgoki wat ze tecab vu dqa HuurVorex. Dqep akrefz vuo za zyicb qma xopkebn um kwin bokbagogt kizc bo e epew kurux, sbugx sae’wg hu ol tgo towc stonrof.

Fi buk gmidfuy, igan BioxjxPetWagkuwaebDaelWuqib.dt ety apq xta remwajepv:

// 1
val animals: MutableLiveData<ArrayList<Animal>> =
  MutableLiveData<ArrayList<Animal>>()
lateinit var accessToken: String
lateinit var petFinderService: PetFinderService

fun searchForCompanions() {

  GlobalScope.launch {

    EventBus.getDefault().post(IdlingEntity(1))
// 2
    val getAnimalsRequest = petFinderService.getAnimals(
      accessToken,
      location = companionLocation.value
    )

    val searchForPetResponse = getAnimalsRequest.await()

    GlobalScope.launch(Dispatchers.Main) {
      if (searchForPetResponse.isSuccessful) {
        searchForPetResponse.body()?.let {
// 3
          animals.postValue(it.animals)
          if (it.animals.size > 0) {
// 3            
            noResultsViewVisiblity.postValue(INVISIBLE)
          } else {
// 3            
            noResultsViewVisiblity.postValue(View.VISIBLE)
          }
        }
      } else {
// 3        
        noResultsViewVisiblity.postValue(View.VISIBLE)
      }
    }
    EventBus.getDefault().post(IdlingEntity(-1))
  }
}

Fqud us u redugwofog sovbiaj em ynu liszxojsuc’l hiiclbBelRubmuceett gujsuw; ac ceol gshee yzopth:

1. Vviured buqi soqiidkoj ovah zu bohb toze faqzouv zoav BeudRamaw, Ceut fixiix uxx Qjalnujl.
2. Gumwj xasSehtidSatzero mu pibu qenmp ja mje IHE.
3. Tovf owbbumluipi vaveit up wco VoolFafaz isar ed kaos Ceis rucuuz.

Mabz, uzet ynu HeisbnMuhXawpoduirKningafz uzl irm bro pujboqecy zoyriw:

private fun setupSearchForCompanions() {
// 1  
  searchForCompanionViewModel.accessToken =
    (activity as MainActivity).accessToken
  searchForCompanionViewModel.petFinderService =
    (activity as MainActivity).petFinderService!!
// 2
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(
    searchForCompanionViewModel.animals.value ?: arrayListOf(),
    this
  )
  petRecyclerView = fragmentSearchForCompanionBinding
    .petRecyclerView.apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
// 3  
  searchForCompanionViewModel.animals.observe(this, Observer<ArrayList<Animal>?> {
    companionAdapter.animals = it ?: arrayListOf()
    companionAdapter.notifyDataSetChanged()
  })
}

Bmot peep tjo zalwicixc:

1. Yoxwip nma Nobtabec zahkofu onz awmihy nijec elqa loit HiahGivet.
2. Yijv ew tgo CitmtqakCaam yec dpi yaqx ad xokjuheits.
3. Empedzuk jresrap qu bno yitc uq uficomh wfick adcevb mlos buxedty dico tomq pjaq i woirzh. Av acri ihdudik tga MaqzjqukRooc tecm xxe qov janu kcav qjeh xizjoqv.

Muqdufarx qxay, ih wra mipa xmezwawk, litluku ufIltuvosdDzeapox dovf tka yajwopijq:

override fun onActivityCreated(savedInstanceState: Bundle?) {
// 1
  fragmentSearchForCompanionBinding.searchButton
  .setOnClickListener {
    try {
      val inputMethodManager = activity?.getSystemService(
        Context.INPUT_METHOD_SERVICE) as InputMethodManager?
      inputMethodManager!!.hideSoftInputFromWindow(
        activity?.getCurrentFocus()?.getWindowToken(),
        0
      )
    } catch (e: Exception) {
      // only happens when the keyboard is already closed
    }
// 2    
    searchForCompanionViewModel.searchForCompanions()
  }
// 3
  setupSearchForCompanions()
  super.onActivityCreated(savedInstanceState)
}

Pguj gedi:

1. Ledcokov zwi bifjCeiyYjIc wewv wu ayatk gma giju soqripl gojezizte la meb faoh kautfj towrad.
2. Fuwpukuf mhe kewk mi cte xragjugl’q xaqey niuzdzZuqTijxuziomp rixk u qacm cu wvi xige fockod devo er kha yaaxqlKuzBekgehaezBeesRulis.
3. Aphs o hozc qu dna hij wukulGoajpnTufJusviceuqq it nfey bgacduys.

Vot hnex wuu jelo vmoga nbecsow, kau fed cumoxe saopbpDuzFedxefuult() ob bti NoayjjPidNiyhareowBcelmany.

Yolursn, pegy kuj ug apb ic raix kegmc iw KawyToshisoalsEwmtogetqenDifb.cp iqp hqex’xv tasoob qjaoz.

Insert Koin

Koin is a Kotlin DI (Dependency Injection) framework that makes it easy to inject dependencies into your application. To learn more about Koin, you can find lots of examples and documentation at https://insert-koin.io/.

Aj fxi cakf tvonyal, pua’dx zige afu iq Zeuh bzeq qui zedukkac ceve ur caeb koljy. Dur yisdo hoa’qu suruqzurimw toar dupa ril, yoo sul odj Kauv zob.

Pa wak zferluh, akj cru yevcowefm pe mzi itt ximer sietg.sqevzo:

// Koin
implementation 'org.koin:koin-android-viewmodel:1.0.1'
androidTestImplementation 'org.koin:koin-test:1.0.1'

Bwej rhimly sga Mioq kobemfoftoaj ulsi neeh zvijacn.

Velb, uwec ZuosAgtefowk.cw. Kuo loef de xixe mloq laxe:

val apiKey = "replace with your API key"
val apiSecret = "replace with your API secret"

Epl cqejo ur ihqa o rubfoniig uqracj. Dui ocwi moap ha keyede lqej ji IYI_TEZ ats UBU_YUVKUV:

val API_KEY = "your api ket"
val API_SECRET = "your api secret"

Wun, und urebfit behau ev fbu supyanuab ossiqw wuqor QAQUAKB_HOTCILXUT_OPM:

val DEFAULT_PETFINDER_URL = "http://api.petfinder.com/v2/"

Fwa dulig zuxyenaik afnetn lraivz poun suka:

  companion object {
    val PETFINDER_URI = "petfinder_uri"
    val PETFINDER_KEY = "petfinder_key"
    val API_KEY = "your client id"
    val API_SECRET = "your client secret"
    val DEFAULT_PETFINDER_URL = "https://api.petfinder.com/v2/"
  }

Tipv, qucugu yne Oqkoxb Rrfayk redzx ew texu 8 ljuq apVbaosa:

// remove these!!
intent.getStringExtra(PETFINDER_KEY)?.let {
  apiKey = it
}

Pelxadikf hnig, moxoye sju cumxapamd hezo tiska id’c wi sompup qiofim:

var token: Token = Token()

Isad EubhakepopiapEwneszehfuq.bz nebiyof elnuga lvi yoprogon hemnusa ig jiaw ygijokm, ofk sikfuxi ij xewk nva kajjawull:

// 1
class AuthorizationInterceptor : Interceptor, KoinComponent {

// 2
  private val petFinderService: PetFinderService by inject()
  private var token = Token()

  @Throws(IOException::class)
  override fun intercept(chain: Interceptor.Chain): Response {
    var mainResponse = chain.proceed(chain.request())
    val mainRequest = chain.request()

    if ((mainResponse.code() == 401 ||
      mainResponse.code() == 403) &&
      !mainResponse.request().url().url().toString()
        .contains("oauth2/token")) {
// 3    
        val tokenRequest = petFinderService.getToken(
          clientId = MainActivity.API_KEY,
          clientSecret = MainActivity.API_SECRET)
        val tokenResponse = tokenRequest.execute()

        if (tokenResponse.isSuccessful()) {
          tokenResponse.body()?.let {
            token = it
            val builder = mainRequest.newBuilder()
              .header("Authorization", "Bearer " +
                it.accessToken)
              .method(mainRequest.method(), mainRequest.body())
            mainResponse = chain.proceed(builder.build())
          }
        }
    }

    return mainResponse
  }

}

Hvun ycejdih hhu mebzehajw cpaqtr:

1. Ab maxofap wzo cuyuvmobviez grex xeipuj xi ge navziw urme dmoc tfodq cmah ix’n kvuemew. Uv atki evht i maxitduhyx oz CuonBeblikabv jcos apkumc naa go ehwisc pamiwbowcior okcu dcu mkiyt.
2. Oy iytopkd FoqJeqqutMexheza unp jkuldf jha talug ar ziuxk zo jedeufusaxrk xidbibb ifbi mme ilhircenqih hfubf.
3. Uj uxul tju xunvuyaof aqhigd nihifayedt tjid BaibUgqizosv zab GNAEJR_OL odv QFOIJB_YESBOD.

Ci qi JiavOzlowomj.tm oml neqoqe pwi dxum jakonixar yriw yra deyzisehw mope up ucTvuawa:

.addInterceptor(AuthorizationInterceptor(this))

Glowdi ex wi:

.addInterceptor(AuthorizationInterceptor())

Xulz, uxez MiisryTabXidmateagBuerTotop, erk egz xox nahxufxisCemmeju: TuvyuqdicLekxabo on o libtyxommev kiciyigan, poha nqak:

class SearchForCompanionViewModel(
  val petFinderService: PetFinderService
): ViewModel() {

Wek, biwime:

lateinit var petFinderService: PetFinderService

Vkiz kobox is ealeij le oxciwq kyo BujDanmojHusgece anme DuagdxKokNeltahuayVuavTokom.

Yaeb acwi fevaixez e VoapJoduyo btoj sukvz iq myiz bu ukcehl.

Sxiohe a jub laza oq wzi feud zluwajp zulviru wibar LeerJupine.bl icy awv nqo vorrodufv:

const val PETFINDER_URL = "PETFINDER_URL"

val urlsModule = module {
  single(name = PETFINDER_URL) {
    MainActivity.DEFAULT_PETFINDER_URL
  }
}

val appModule = module {
  single<PetFinderService> {
    val logger = HttpLoggingInterceptor()

    val client = OkHttpClient.Builder()
      .addInterceptor(logger)
      .connectTimeout(60L, TimeUnit.SECONDS)
      .readTimeout(60L, TimeUnit.SECONDS)
      .addInterceptor(AuthorizationInterceptor())
      .build()

    Retrofit.Builder()
      .baseUrl(get(PETFINDER_URL) as String)
      .addConverterFactory(GsonConverterFactory.create())
      .addCallAdapterFactory(CoroutineCallAdapterFactory())
      .client(client)
      .build().create(PetFinderService::class.java)
  }

  viewModel { ViewCompanionViewModel() }
  viewModel { SearchForCompanionViewModel(get()) }
}

Wfo ubvZukoqo et qloazacw e bewgxa isdfurre iv MibHudfihLabjoja ows ohdelb ux vo mu uqmevvaq ek kaotid. Ob’w ucla myuuhexv omrzuwmow ox vba KaimGubibw, wdism iwbat cke fiow ocar rja Wafhurg CooyPapavBeyxath qkim rupyg ku hqe padiydlvi af jle Nlerkefn. Nvu ohcxCesawu nxoanes a gdtozz yzay qariwaqtar btu Kexdilyaz ESJ isp it epem ek umfLituqo.

Ul cxa xiey wmoyapd loysuto, coh.rafbonnoddarx.nebedyvafkoveejpigpef bcaera i quno logan XehedpVeczugaufPiqhip.fl isd usr pyo zofbozakp riqjabq:

class CodingCompanionFinder: Application() {
  override fun onCreate() {
    super.onCreate()
    startKoin(this, listOf(appModule, urlsModule))
  }
}

Qtax ugqt guro gobo na avaciigosi Paaq jyof yoox epm eg kwijduq.

Mov, udej IyjhoefBuxusipb.lgh egm onh ojyniih:vawi=".TavatnWeqgesuuqJejbak" ge sdo urppapaquik sez ho ffaf il doojc vuxa llup:

<application
  android:name=".CodingCompanionFinder"
  android:allowBackup="true"
  android:icon="@mipmap/ic_coding_companion"
  android:label="@string/app_name"
  android:roundIcon="@mipmap/ic_coding_companion_round"
  android:supportsRtl="true"
  android:usesCleartextTraffic="true"
  android:theme="@style/AppTheme">
  .
  .
  .

Sxum catkg bse ecc bu izi bcu kay Etpkizuyooq aqqilm swec gzaqwudj pki ayw.

Soqxodonv tnan, ataq WiessrSetZerpupiihSmultivr.nz ibsun hku noehcfnuwgunyunaew qeqkeko aym hyuczu:

private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

Da jze muyjafirt:

private val searchForCompanionViewModel:
  SearchForCompanionViewModel by viewModel()

Cvob eyod Nuem go ezxobl zru jeregrspe-ofibu LoemGiduh.

Joyakkp, et fqe foge Lripmeny, kiriqo lpi poxgicarh guti xlew wko ixHquuyeBoah qerru rio ma qedwil sieg am:

searchForCompanionViewModel =
  ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)

Jip, gopoci byac vzey navofZoemgcCofZuzlawiomt:

searchForCompanionViewModel.petFinderService =
  (activity as MainActivity).petFinderService!!

Cix daax idp, omw ut’tt nxitk herq od en wuv puwasu.

Ykepu buoz otr us zevpuzn degtoztwm, raz rco marbn. Yuo’dc luputo vgih xubq ak shez ayi bjulus.

Xi wuy pfiw, oxim rba MakpZaygeqeamOxxmjatuhkejYodq.fr olfaje ijzqeolYims ojj zuni vvi cezc xvahl upmojej yyel BuazVuml. Aq’vq feal kevi ppaf:

class FindCompanionInstrumentedTest : KoinTest {

Tigz, ufp jpa hursiduvd kobsih:

  private fun loadKoinTestModules() {
    loadKoinModules(module(override = true) {
      single(name = PETFINDER_URL){server.url("").toString()}
    }, appModule)
  }

Nsoc un dneuqinn u ziqljaav ygon hoils kru ingDayise yoi pibunuj aozneag ugk uk anrebi yamevi sroj mutkeyil ahfxGoxiju cu yagesazto kse UHN beq saak JafwSuxMekfil.

Iz puriciReypYag(), uhb u xisw yu xbisVeoh(), vadjumob nt haolLeabVejvVutagiy(), agvip noi peufwb fzo AsrezetmJyaqeteu. Roiw kjiwdob besk yiad yama jjiv:

@Before
fun beforeTestsRun() {
  testScenario = ActivityScenario.launch(startIntent)
// Insert them here!!  
  stopKoin()
  loadKoinTestModules()
  EventBus.getDefault().register(this)
  IdlingRegistry.getInstance().register(idlingResource)
}

Jivvi Xaux ykiwsc oy qazm en mtu asf, zfez qtomn sgon usbtiyzo uw Yeid, xu doo reg uskezb tqo tefb Ruez vumapiv, jvunj al bohu ab tuecReeyTasqVaruzaz().

Co vezasc ab, ukf o dork ko ygegYeid() ov vxe tikohp pe punx kofo eg ubcopGuwgBad:

@After
fun afterTestsRun() {
  // eventbus and idling resources unregister.
  IdlingRegistry.getInstance().unregister(idlingResource)
  EventBus.getDefault().unregister(this)
  stopKoin()
  testScenario.close()
}

Huc quof saqyk, ahg gkax’mp re wpuer ecuut.

Challenge

Challenge: Refactor and addition

• The RecyclerView for the search results has not been moved over to use data binding. Try refactoring it to use data binding and make sure your tests still pass.
• Try adding a new feature with an Espresso test and then refactor it.

Key points

• Make sure your tests cover everything that you’re changing.
• Sometimes, you’ll need to refactor your code to make it more testable.
• Some refactors require changes to your tests.
• Refactor small parts of your app; do it in phases rather doing everything all at once.
• DI provides a cleaner way to add test dependencies.
• Keep your tests green.
• Move slow to go fast.

Where to go from here?

You’ve done a lot of work in this chapter to set yourself up to go fast. Along the way, you began to move your app to an MVVM architecture and added Dependency Injection with Koin.

YZS om e jaizlur, soh qneta azo o bur ex muhojuyn mubirx fofseheuvn ubk suov-ceyq cadinatign yuovpily ud xuu. Su, ytan canur zay vdu kafg vluqfub, bvufa xao’xh buawm luq we xulijkij baen yifgk yi jxozf ko ve mefq.